Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloud_tasks_queue: supress permadiffs on backoff settings #5920

Conversation

modular-magician
Copy link
Collaborator

Add tpgresource.DurationDiffSuppress to min / max backoff
Fixes hashicorp/terraform-provider-google#15166

h/t to @edwardmedia for the pointer

Note: maxRetryDuration already has a custom diff function: suppressOmittedMaxDuration() - for now, I didn't touch that one

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

cloud_tasks: suppressed time-unit permadiffs on `google_cloud_tasks_queue` min and max backoff settings

Derived from GoogleCloudPlatform/magic-modules#8359

@modular-magician modular-magician merged commit b42ec5c into hashicorp:main Jul 20, 2023
@modular-magician modular-magician deleted the downstream-pr-c9cc1628e56054606f8a6e08bfe64ec3ed62cecb branch November 16, 2024 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

time unit permadrift on google_cloud_tasks_queue
1 participant