Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax the validation of master ipv4 cidr for GKE with private endpoint subnetwork #6025

Conversation

modular-magician
Copy link
Collaborator

Master ipv4 cidr is not required when a private endpoint subnetwork is provided. This change relaxes an existing validation.

fixes hashicorp/terraform-provider-google#15064

I was unable to run the relevant acceptance tests because I do not have the permissions to create a network or subnetworks in the project owned by my employer. I built the provider locally and verified manually that I could create a GKE cluster with the expected configuration.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

container: 'master_ipv4_cidr_block' is not required when 'private_endpoint_subnetwork' is provided for 'google_container_cluster`

Derived from GoogleCloudPlatform/magic-modules#8338

…t subnetwork (hashicorp#8338)

Co-authored-by: Riley Karson <[email protected]>
Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 5b3eb5f into hashicorp:main Aug 7, 2023
@modular-magician modular-magician deleted the downstream-pr-faeec759277eaa78f424744ae91367240b0c0be8 branch November 16, 2024 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support use of Private Service Connect endpoint in GKE google_container_cluster resource
1 participant