Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate DataProfileResult and DataQualityResult for Dataplex Datascans. #6090

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/8593.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:deprecation
dataplex: deprecated the following `google_dataplex_datascan` fields: `dataProfileResult` and `dataQualityResult`
```
5 changes: 0 additions & 5 deletions .teamcity/components/generated/packages.kt
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,6 @@ var packages = mapOf(
"displayName" to "Environment Variables",
"path" to "./google-beta/envvar"
),
"fwmodels" to mapOf(
"name" to "fwmodels",
"displayName" to "Framework Models",
"path" to "./google-beta/fwmodels"
),
"fwprovider" to mapOf(
"name" to "fwprovider",
"displayName" to "Framework Provider",
Expand Down
2 changes: 2 additions & 0 deletions google-beta/services/dataplex/resource_dataplex_datascan.go
Original file line number Diff line number Diff line change
Expand Up @@ -392,6 +392,7 @@ Only relevant if a minValue has been defined. Default = false.`,
"data_profile_result": {
Type: schema.TypeList,
Computed: true,
Deprecated: "dataProfileResult will be removed from Terraform output fields in 5.0.0",
Description: `The result of the data profile scan.`,
Elem: &schema.Resource{
Schema: map[string]*schema.Schema{
Expand Down Expand Up @@ -608,6 +609,7 @@ Only relevant if a minValue has been defined. Default = false.`,
"data_quality_result": {
Type: schema.TypeList,
Computed: true,
Deprecated: "dataQualityResult will be removed from Terraform output fields in 5.0.0",
Description: `The result of the data quality scan.`,
Elem: &schema.Resource{
Schema: map[string]*schema.Schema{
Expand Down
6 changes: 6 additions & 0 deletions website/docs/guides/version_5_upgrade.html.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,12 @@ These two unsupported fields were introduced incorrectly. They are now removed.

This unsupported field was introduced incorrectly. It is now removed.

## Resource: `google_dataplex_datascan`

### `dataQualityResult` and `dataProfileResult` output fields are now removed

`dataQualityResult` and `dataProfileResult` were output-only fields which listed results for the latest job created under a Datascan. These were problematic fields that are unlikely to be relevant in a Terraform context. Removing them reduces the likelihood of additional parsing errors, and reduces maintenance overhead for the API surface.

## Resource: `google_compute_router_nat`

### `enable_endpoint_independent_mapping` now defaults to API's default value which is `FALSE`
Expand Down
2 changes: 2 additions & 0 deletions website/docs/r/dataplex_datascan.html.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -499,10 +499,12 @@ In addition to the arguments listed above, the following computed attributes are
The type of DataScan.

* `data_quality_result` -
(Deprecated)
The result of the data quality scan.
Structure is [documented below](#nested_data_quality_result).

* `data_profile_result` -
(Deprecated)
The result of the data profile scan.
Structure is [documented below](#nested_data_profile_result).

Expand Down