Add initial version of a plugin-framework provider config test, move code between packages to allow tests #6180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…code between packages to allow tests (hashicorp#8797) * Add initial version of plugin framework provider config test affected by inaccessible functions * Move `ReplaceVarsForFrameworkTest` to `fwresource` package This mirrors how old, ReplaceVars* functions are in the `tpgresource` package * Move functions for changing ENVs in tests to `acctest` package, update usage * Move `GenerateFakeCredentialsJson` function to `acctest` package, update usage * Refactor provider config tests to use plugin-framework types * Add all test cases to match equivalent SDK provider config tests Some test cases currently fail due to different handling of empty values by the SDK and plugin framework * Add test case about handling of Unknown values for `project` * Update tests to check values in BOTH the data model and provider config struct after `LoadAndValidateFramework` runs Signed-off-by: Modular Magician <[email protected]>
modular-magician
deleted the
downstream-pr-1b2c1a12b1ca61943f699da99510d8e67b07b756
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR begins to add tests that match equivalent tests created for the SDK version of the provider config code. The motivation of adding these tests is to ensure parity between the SDK and plugin framework versions of the provider config code, as muxing the provider resulted in bugs like: hashicorp/terraform-provider-google#14255
Currently there isn't parity in how the two bits of code handle empty strings (see commented out test cases) and I will address that in a separate PR to this one.
To allow the tests to be created I needed to move code between packages to allow reuse of test-related functions and to avoid circular dependencies.
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintin the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#8797