Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #12883 #6259

Conversation

modular-magician
Copy link
Collaborator

Fixed hashicorp/terraform-provider-google#12883

Make one CloudResourceManager call per monitored_project terraform resource rather than per (monitored_project * "sibling" projects)

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

monitoring: fixed scaling issues when deploying terraform changes with many `google_monitoring_monitored_project`

Derived from GoogleCloudPlatform/magic-modules#8738

* Fix issue #12883

Make one CloudResourceManager call per monitored_project terraform
resource rather than per (monitored_project * "sibling" projects)

* Add comment

* Correct build errors

* Fix build errors

* Add debug logs

* Fix printf

* Fix match between TF resource and API response

* Fix from non-matching to matching condition

* Correct documentation

* Correct documentation

* Fix go build issues

* Convert projectNumber to string

* Use correct string conversion

* Move comment

* Add debug logs to monitored project encoder

* correct delete_url

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 1b15e64 into hashicorp:main Sep 13, 2023
@modular-magician modular-magician deleted the downstream-pr-86b9c51de3e97f852b6b0b721582a155196f1b28 branch November 16, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant