Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change container node pool defaults #6329

Conversation

modular-magician
Copy link
Collaborator

fixes hashicorp/terraform-provider-google#6236

fixes hashicorp/terraform-provider-google#13706

both auto repair and auto upgrade default to true according to these docs and verified in testing
https://cloud.google.com/kubernetes-engine/docs/how-to/node-auto-repair
https://cloud.google.com/kubernetes-engine/docs/how-to/node-auto-upgrades

upgrade guide: GoogleCloudPlatform/magic-modules#8969

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

container: removed default for `logging_variant` in `google_container_node_pool`
container: changed `management.auto_repair` and `management.auto_upgrade` defaults to true in `google_container_node_pool`

Derived from GoogleCloudPlatform/magic-modules#8967

@modular-magician modular-magician merged commit 0696e16 into hashicorp:FEATURE-BRANCH-major-release-5.0.0 Sep 21, 2023
@modular-magician modular-magician deleted the downstream-pr-7bef6de2e31ca58916956b4efa0c3423d64f0131 branch November 16, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant