Setting ForceNew to false in the taint block of the GKE nodepool node_config resource #6536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_config resource (hashicorp#9248) * Removing ForceNew from taint in change in a nodepool node_config The context for this, even if I didn't find that API doc, is that gcloud and the Console UI do not require the node_pool recreation. * Update resource_container_node_pool.go.erb * Nodepool NodeConfig Taint update func * TestAccContainerNodePool_withTaintsUpdate * Update resource_container_node_pool_test.go.erb * Update resource_container_node_pool_test.go.erb * update ForceNew fields as per the review [upstream:cd09f0916518907c6ebe72b6054f2f7add79552e] Signed-off-by: Modular Magician <[email protected]>
modular-magician
deleted the
downstream-pr-cd09f0916518907c6ebe72b6054f2f7add79552e
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The context for this, even if I didn't find that API doc, is that gcloud and the Console UI do not require the node_pool recreation.
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#9248