Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed artifact_registry_repository permadiff in unordered array #6691

Conversation

modular-magician
Copy link
Collaborator

Suppress diff of artifact_registry_repository.virtual_repository_config.upstream_policies order using set semantics.
Fixes hashicorp/terraform-provider-google#16381

Release Note Template for Downstream PRs (will be copied)

artifactregistry: fixed permadiff due to unsorted `virtual_repository_config` array in `google_artifact_registry_repository`

Derived from GoogleCloudPlatform/magic-modules#9376

* fixed permadiff in unordered array

* changed permadiff fix strategy for upstream policies

* removed no-op field

* change diff semantics to use schema.Set

* updated virtual example with intentional out-of-order priorities

* update virtual policy comparison to not panic on bad cast (if possible)
[upstream:9988136d1c8e3ef6dfb0506fe78fc07cd4a0097f]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit db602d6 into hashicorp:main Dec 1, 2023
4 checks passed
@modular-magician modular-magician deleted the downstream-pr-9988136d1c8e3ef6dfb0506fe78fc07cd4a0097f branch November 16, 2024 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Permadiff on google_artifact_registry_repository.virtual_repository_config
1 participant