add numeric_id field into google_compute_network resource
#6719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add numberic_id field * add flattener, encoders, and id field for numeric_id use * WIP: add numberId test * add value checks for id and numeric_id * add strconv * use decoder to store id into numericId after API request * remove network check and add suffix variable * add endlines * typo * Updated test to explicitly check numeric_id and id with ResourceAttr * update regex to be more strict on numeric_id check [upstream:d6ce7020cd1e2a490a93c91ccc643531dba8bae7] Signed-off-by: Modular Magician <[email protected]>
modular-magician
deleted the
downstream-pr-d6ce7020cd1e2a490a93c91ccc643531dba8bae7
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will fix an issue that relates to tag binding. Where it is only possible to use an id of a resource for binding rather than
name. Because of the use ofidwithin the terraform providers,numeric_idis used as a field which is the unique resource identifier for the resource.marked as
idin API documentation but will be named asnumeric_idin providerRelease Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#9473