Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Failing test(s): TestAccLoggingBucketConfigProject_* #6801

Conversation

modular-magician
Copy link
Collaborator

Based off the failing test below, it seems as though we would need to update the use of _Default. My understanding is that the logging bucket _Default and _Required have already been created. Making it unnecessary to create a logging resource with the same bucket_id as ones that are already made. This is also mentioned in the google docs here

Will be running test through Magic Modules mostly since org_id is necessary to fix this.

------- Stdout: -------
=== RUN   TestAccLoggingBucketConfigProject_analyticsEnabled
=== PAUSE TestAccLoggingBucketConfigProject_analyticsEnabled
=== CONT  TestAccLoggingBucketConfigProject_analyticsEnabled
    vcr_utils.go:152: Step 1/4 error: Error running apply: exit status 1
        Error: Error creating Bucket: googleapi: Error 400: Resource id can only start with an alphanumber character
          with google_logging_project_bucket_config.basic,
          on terraform_plugin_test.tf line 8, in resource "google_logging_project_bucket_config" "basic":
           8: resource "google_logging_project_bucket_config" "basic" {
--- FAIL: TestAccLoggingBucketConfigProject_analyticsEnabled (35.26s)
FAIL

fixes hashicorp/terraform-provider-google#16695

Release Note Template for Downstream PRs (will be copied)


Derived from GoogleCloudPlatform/magic-modules#9674

* change _Default bucket_id usage

* remove from unrelated tests

* remove indexconfigs change

* add billing_acccount to failing tests

* add billingaccount variable to project tfconfig
[upstream:72363f154fa32650028fadf61775a5870e248924]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 11de653 into hashicorp:main Jan 3, 2024
4 checks passed
@modular-magician modular-magician deleted the downstream-pr-72363f154fa32650028fadf61775a5870e248924 branch November 16, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccLoggingBucketConfigProject_*
1 participant