Add compute_machine_types datasource #6903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add compute_machine_types datasource * Add documentation for compute_machine_types datasource [upstream:7a789b657e3de8471a629c449d043255980bbc3f] Signed-off-by: Modular Magician <[email protected]>
modular-magician
deleted the
downstream-pr-7a789b657e3de8471a629c449d043255980bbc3f
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a plural version of hashicorp/terraform-provider-google#5606 which should solve the same use-cases while also being more flexible.
Specifically, a plural datasource allows a terraform module to be used across regions without needing to override a machine_type variable based on machine type availability. The plural datasource can return an empty list rather than fail the terraform operation if a specific machine type isn't available in the given zone.
Regarding the test, similar to other read-only APIs I'm only checking the existence of attributes rather than requesting a specific machine type and checking its values, since different test environments may have different machine type availability.
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#9819