Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change region field required to default_from_api #7384

Conversation

modular-magician
Copy link
Collaborator

Change region field for google_compute_region_ssl_policy to be optional and to be inferred from environment.

Fixes hashicorp/terraform-provider-google#17142

  • Searched through the issue tracker for an open issue that this either resolves or contributes.
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests). - read only field
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: Changed `google_compute_region_ssl_policy`'s `region` field to optional and allow to be inferred from environment

Derived from GoogleCloudPlatform/magic-modules#10724

[upstream:2f6d3ced689d299474ec30ef7b38838a2e62c1d4]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit ce61546 into hashicorp:main May 17, 2024
4 checks passed
@modular-magician modular-magician deleted the downstream-pr-2f6d3ced689d299474ec30ef7b38838a2e62c1d4 branch November 16, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant