Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix identity type comparison for service perimeters #8648

Conversation

modular-magician
Copy link
Collaborator

Fixes hashicorp/terraform-provider-google/issues/17023. The API does not return the IDENTITY_TYPE_UNSPECIFIED enum value when it is set so we can treat that as an empty value.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

accesscontextmanager: fixed comparison of `identity_type` in `ingress_from` and `egress_from` when the `IDENTITY_TYPE_UNSPECIFIED` is set

Derived from GoogleCloudPlatform/magic-modules#12267

[upstream:343132cfcaa07a03a385461bfe261580d4624ac4]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit c9ed1e6 into hashicorp:main Nov 7, 2024
@modular-magician modular-magician deleted the downstream-pr-343132cfcaa07a03a385461bfe261580d4624ac4 branch November 16, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant