Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if ga-only logic can be removed from iam_test_file.go.erb file #12610

Closed
SarahFrench opened this issue Sep 20, 2022 · 4 comments · Fixed by GoogleCloudPlatform/magic-modules#7185 or hashicorp/terraform-provider-google-beta#5225
Assignees
Labels

Comments

@SarahFrench
Copy link
Member

In Magic Modules' mmv1/templates/terraform/examples/base_configs/iam_test_file.go.erb file there's ga-only logic around import steps of acceptance tests and also around this code

<% unless object.min_version.name == "ga" -%>
		Providers:    testAccProvidersOiCS,
<% else -%>
		Providers:    testAccProviders,
<% end -%>

I think this can be removed as it originated a few years ago. This topic came up in another PR of mine (where I touched files for IAM test generation), but I think removing this logic is good to keep in a separate PR. Making this issue to keep track of this task

@melinath
Copy link
Collaborator

melinath commented Jan 9, 2023

this logic being excluded in beta caused the errors in GoogleCloudPlatform/magic-modules#6989 to go undetected. I thought we had a previous ticket to start running beta import tests for IAM but I can't find it any more.

@melinath
Copy link
Collaborator

melinath commented Jan 10, 2023

Here's the previous ticket - the fix enabled import tests for beta resources but not for beta IAM resources. #7603

@SarahFrench
Copy link
Member Author

Thanks - I'll revisit my draft PR for this issue!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.