-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check if ga
-only logic can be removed from iam_test_file.go.erb
file
#12610
Check if ga
-only logic can be removed from iam_test_file.go.erb
file
#12610
Comments
this logic being excluded in beta caused the errors in GoogleCloudPlatform/magic-modules#6989 to go undetected. I thought we had a previous ticket to start running beta import tests for IAM but I can't find it any more. |
Here's the previous ticket - the fix enabled import tests for beta resources but not for beta IAM resources. #7603 |
Thanks - I'll revisit my draft PR for this issue! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
In Magic Modules'
mmv1/templates/terraform/examples/base_configs/iam_test_file.go.erb
file there's ga-only logic around import steps of acceptance tests and also around this codeI think this can be removed as it originated a few years ago. This topic came up in another PR of mine (where I touched files for IAM test generation), but I think removing this logic is good to keep in a separate PR. Making this issue to keep track of this task
The text was updated successfully, but these errors were encountered: