datacatalog - bump Taxonomy and PolicyTag to ga #6989

DrFaust92 · 2022-12-18T17:18:01Z

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

datacatalog - bump Taxonomy and PolicyTag to ga

modular-magician · 2022-12-18T17:18:59Z

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @melinath, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

Ensuring it's backwards compatible, covers common error cases, etc.
Summarizing the change into a user-facing changelog note.
Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

modular-magician · 2022-12-18T17:39:48Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 15 files changed, 2059 insertions(+), 26 deletions(-))
Terraform Beta: Diff ( 8 files changed, 71 insertions(+), 68 deletions(-))
TF Validator: Diff ( 9 files changed, 808 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 3 files changed, 7 deletions(-))

mmv1/products/datacatalog/terraform.yaml

modular-magician · 2022-12-18T18:04:50Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 15 files changed, 2049 insertions(+), 32 deletions(-))
Terraform Beta: Diff ( 8 files changed, 80 insertions(+), 93 deletions(-))
TF Validator: Diff ( 9 files changed, 808 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 3 files changed, 1 insertion(+), 11 deletions(-))

modular-magician · 2022-12-18T18:55:56Z

Tests analytics

Total tests: 2354
Passed tests 2095
Skipped tests: 247
Failed tests: 12

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccLoggingBucketConfigProject_cmekSettings|TestAccFirebaserulesRelease_BasicRelease|TestAccDataCatalogTaxonomy_dataCatalogTaxonomyBasicExample|TestAccContainerCluster_withInvalidGatewayApiConfigChannel|TestAccDataCatalogPolicyTag_dataCatalogTaxonomiesPolicyTagChildPoliciesExample|TestAccDataCatalogPolicyTag_dataCatalogTaxonomiesPolicyTagBasicExample|TestAccDataCatalogTaxonomyIamPolicyGenerated|TestAccDataCatalogTaxonomyIamMemberGenerated|TestAccDataCatalogPolicyTagIamPolicyGenerated|TestAccDataCatalogTaxonomyIamBindingGenerated|TestAccDataCatalogPolicyTagIamMemberGenerated|TestAccDataCatalogPolicyTagIamBindingGenerated

modular-magician · 2022-12-18T18:57:17Z

Tests passed during RECORDING mode:
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccDataCatalogTaxonomy_dataCatalogTaxonomyBasicExample[Debug log]
TestAccContainerCluster_withInvalidGatewayApiConfigChannel[Debug log]
TestAccDataCatalogPolicyTag_dataCatalogTaxonomiesPolicyTagChildPoliciesExample[Debug log]
TestAccDataCatalogPolicyTag_dataCatalogTaxonomiesPolicyTagBasicExample[Debug log]

Tests failed during RECORDING mode:
TestAccDataCatalogTaxonomyIamPolicyGenerated[Error message] [Debug log]
TestAccDataCatalogTaxonomyIamMemberGenerated[Error message] [Debug log]
TestAccDataCatalogPolicyTagIamPolicyGenerated[Error message] [Debug log]
TestAccDataCatalogTaxonomyIamBindingGenerated[Error message] [Debug log]
TestAccDataCatalogPolicyTagIamMemberGenerated[Error message] [Debug log]
TestAccDataCatalogPolicyTagIamBindingGenerated[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2023-01-01T20:41:44Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 15 files changed, 2049 insertions(+), 32 deletions(-))
Terraform Beta: Diff ( 8 files changed, 80 insertions(+), 93 deletions(-))
TF Validator: Diff ( 9 files changed, 808 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 3 files changed, 1 insertion(+), 11 deletions(-))

modular-magician · 2023-01-01T21:21:36Z

Tests analytics

Total tests: 2380
Passed tests 2123
Skipped tests: 248
Failed tests: 9

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccLoggingBucketConfigProject_cmekSettings|TestAccFirebaserulesRelease_BasicRelease|TestAccContainerCluster_withInvalidGatewayApiConfigChannel|TestAccDataCatalogTaxonomyIamPolicyGenerated|TestAccDataCatalogPolicyTagIamBindingGenerated|TestAccDataCatalogPolicyTagIamMemberGenerated|TestAccDataCatalogTaxonomyIamMemberGenerated|TestAccDataCatalogTaxonomyIamBindingGenerated|TestAccDataCatalogPolicyTagIamPolicyGenerated

modular-magician · 2023-01-01T21:22:52Z

Tests passed during RECORDING mode:
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccContainerCluster_withInvalidGatewayApiConfigChannel[Debug log]

Tests failed during RECORDING mode:
TestAccDataCatalogTaxonomyIamPolicyGenerated[Error message] [Debug log]
TestAccDataCatalogPolicyTagIamBindingGenerated[Error message] [Debug log]
TestAccDataCatalogPolicyTagIamMemberGenerated[Error message] [Debug log]
TestAccDataCatalogTaxonomyIamMemberGenerated[Error message] [Debug log]
TestAccDataCatalogTaxonomyIamBindingGenerated[Error message] [Debug log]
TestAccDataCatalogPolicyTagIamPolicyGenerated[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

melinath · 2023-01-09T23:56:34Z

I looked into this a bit and found that the failing tests are all due to import issues; these test steps previously weren't being generated in beta due to the code described here: hashicorp/terraform-provider-google#12610 Hopefully we will be able to address that at some point. I still need to look closer in terms of fixing the import code.

melinath · 2023-01-30T22:03:27Z

@DrFaust92 I just merged #7137 which should fix the import for datacatalog taxonomy. Could you rebase off the latest main branch to see if that fixes things?

melinath

see above

DrFaust92 · 2023-01-30T23:30:20Z

Sure, will try

…

On Tue, 31 Jan 2023 at 0:03 Stephen Lewis (Burrows) < ***@***.***> wrote: ***@***.**** requested changes on this pull request. see above — Reply to this email directly, view it on GitHub <#6989 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIA2W7Q44JW3RYTHH4UYCHTWVA3EVANCNFSM6AAAAAATCT3ZGY> . You are receiving this because you were mentioned.Message ID: ***@***.***>

melinath · 2023-01-30T23:34:51Z

Oh, it looks like policytag is likely still going to fail, actually. That may need a separate fix. Would you want to split taxonomy into a separate PR for easier review?

DrFaust92 · 2023-01-31T19:33:42Z

@melinath how would splitting help? missing something here taxonomy also fails same as before. the way the test is generated cant work here. the get operation needs the uuid that created after create. so the primary_resource_name: "fmt.Sprintf(\"tf_test_my_taxonomy%s\", context[\"random_suffix\"])" wouldnt work as it doesnt get that id

melinath · 2023-02-02T17:16:07Z

the way the test is generated cant work here. the get operation needs the uuid that created after create.

Yep, you're absolutely right, I got too excited. :-/

melinath · 2023-02-03T16:52:50Z

It looks like you could work around this by switching these IAM resources to be handwritten (since we don't have a way to only skip generating the tests at the moment :-/) and then doing something similar to this: test that pulls value out of test, function that does the pulling

cc @SarahFrench who suggested this on a PR related to running import tests for beta resources, which ran into this same issue.

If you want to take a stab at this I think that would be fine; otherwise this will be blocked until she's done either skipping the tests or fixing them (which will hopefully be soon :-) )

SarahFrench · 2023-02-03T20:02:18Z

I think the 'pulling generated values out of a test' approach would still require the tests to be handwritten (as I don't think custom code can be added into generated IAM tests). But at least then the handwritten tests would be able to include an import step!

SarahFrench · 2023-02-07T17:13:31Z

Update: I've implemented skipping of IAM import steps in this PR's commit 5b7760b . In it's current implementation it's a blanket exclusion of IAM import steps for any IAM tests for a given parent resource.

SarahFrench · 2023-02-20T17:42:54Z

Update: I've merged my PR where I have added the ability to skip import steps in acceptance tests for IAM resources.

I that PR I made these change to mmv1/products/datacatalog/api.yaml to skip imports in tests for Data Catalog's Taxonomy and PolicyTag resources.

If you rebase/merge those changes in here then you don't need to worry about the tests that rely on uuid's that are made by the API during resource creation

DrFaust92 · 2023-02-25T18:33:06Z

Thanks SarahFrench ive rebased and will test

DrFaust92 · 2023-02-25T18:37:33Z

--- PASS: TestAccDataCatalogTaxonomyIamBindingGenerated (60.48s)
looks good!

melinath · 2023-02-27T16:10:54Z

/gcbrun

modular-magician · 2023-02-27T16:27:44Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 15 files changed, 1994 insertions(+), 32 deletions(-))
Terraform Beta: Diff ( 8 files changed, 18 insertions(+), 93 deletions(-))
TF Validator: Diff ( 9 files changed, 808 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 3 files changed, 1 insertion(+), 11 deletions(-))

modular-magician · 2023-02-27T17:12:02Z

Tests analytics

Total tests: 2473
Passed tests 2209
Skipped tests: 255
Failed tests: 9

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccComputeForwardingRule_update|TestAccDataCatalogTaxonomyIamPolicyGenerated|TestAccDataCatalogPolicyTagIamPolicyGenerated|TestAccDataCatalogPolicyTagIamMemberGenerated|TestAccDataCatalogPolicyTagIamBindingGenerated|TestAccDataCatalogTaxonomyIamMemberGenerated|TestAccDataCatalogTaxonomyIamBindingGenerated|TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample

modular-magician · 2023-02-27T18:05:57Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccComputeForwardingRule_update[Debug log]
TestAccDataCatalogTaxonomyIamPolicyGenerated[Debug log]
TestAccDataCatalogPolicyTagIamPolicyGenerated[Debug log]
TestAccDataCatalogPolicyTagIamMemberGenerated[Debug log]
TestAccDataCatalogPolicyTagIamBindingGenerated[Debug log]
TestAccDataCatalogTaxonomyIamMemberGenerated[Debug log]
TestAccDataCatalogTaxonomyIamBindingGenerated[Debug log]

Tests failed during RECORDING mode:
TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

melinath

lgtm - failure is unrelated

melinath · 2023-02-27T19:34:14Z

should've done this prior to merge, but out of paranoia, running tests for GA https://ci-oss.hashicorp.engineering/buildConfiguration/GoogleCloud_ProviderGoogleCloudMmUpstream/378717

melinath · 2023-02-27T21:10:55Z

update: all passed 🎉

…6989) * update Taxonomy and PolicyTag to ga * update Taxonomy and PolicyTag to ga * refactor * refactor

* main: (41 commits) update the test cases to resolve resourcename not found error Adds `grpc` field to `liveness_probe` and `startup_probe` to `google_cloud_run_v2_service` resource (GoogleCloudPlatform#6987) Upgrade DCL to v1.34 (GoogleCloudPlatform#7276) Add max_distance field to group placement policy (GoogleCloudPlatform#7354) Add stateful_ips to region_per_instance_config and per_instance_config (GoogleCloudPlatform#7316) Added support for workload-vulnerability-scanning and workload-config-audit (GoogleCloudPlatform#7310) datacatalog - bump Taxonomy and PolicyTag to ga (GoogleCloudPlatform#6989) Added best practices documentation for ForceNew fields (GoogleCloudPlatform#7127) Split resources in "B" products (GoogleCloudPlatform#7350) force recreate on master_config.num_instances (GoogleCloudPlatform#7349) Fix DataFusion instance versions used in tests (GoogleCloudPlatform#7343) remove duplicate word in Cluster.yaml (GoogleCloudPlatform#7347) Move more billing tests that require permissions beyond Billing User to master billing account (GoogleCloudPlatform#7344) Remove artifact repository beta URL, fixup handwritten tests (GoogleCloudPlatform#7345) Cloud Workstations - Workstation Config (GoogleCloudPlatform#7017) Add missing `type` argument to data source docs (GoogleCloudPlatform#7341) Fix caps in spanner resource schema accesses (GoogleCloudPlatform#7346) Downgrade Go to 1.18, modify comments (GoogleCloudPlatform#7339) feat: Add support for deletion_policy on shared vpc service project (GoogleCloudPlatform#7283) fixed virtual field update issues (GoogleCloudPlatform#7318) ...

…6989) * update Taxonomy and PolicyTag to ga * update Taxonomy and PolicyTag to ga * refactor * refactor

DrFaust92 mentioned this pull request Dec 18, 2022

update BigqueryDatapolicy to ga #6797

Merged

5 tasks

modular-magician requested a review from melinath December 18, 2022 17:19

DrFaust92 commented Dec 18, 2022

View reviewed changes

mmv1/products/datacatalog/terraform.yaml Show resolved Hide resolved

DrFaust92 force-pushed the data-catalog-beta branch from f780950 to 5f459aa Compare January 1, 2023 20:25

DrFaust92 marked this pull request as ready for review January 4, 2023 05:47

melinath mentioned this pull request Jan 9, 2023

Check if ga-only logic can be removed from iam_test_file.go.erb file hashicorp/terraform-provider-google#12610

Closed

melinath requested changes Jan 30, 2023

View reviewed changes

melinath self-requested a review February 3, 2023 16:45

melinath self-assigned this Feb 14, 2023

DrFaust92 added 3 commits February 25, 2023 20:12

update Taxonomy and PolicyTag to ga

813feae

update Taxonomy and PolicyTag to ga

1a5a682

refactor

26eb82d

refactor

2bb0e91

DrFaust92 force-pushed the data-catalog-beta branch from 5f459aa to 2bb0e91 Compare February 25, 2023 18:32

DrFaust92 requested a review from a team as a code owner February 25, 2023 18:32

SarahFrench mentioned this pull request Feb 27, 2023

Failing test(s): TestAccWorkstationsWorkstationConfig_ hashicorp/terraform-provider-google#13847

Closed

melinath approved these changes Feb 27, 2023

View reviewed changes

melinath merged commit 02108d4 into GoogleCloudPlatform:main Feb 27, 2023

mdtro pushed a commit to mdtro/magic-modules that referenced this pull request Mar 2, 2023

datacatalog - bump Taxonomy and PolicyTag to ga (GoogleCloudPlatform#…

7318b0f

…6989) * update Taxonomy and PolicyTag to ga * update Taxonomy and PolicyTag to ga * refactor * refactor

ericayyliu pushed a commit to ericayyliu/magic-modules that referenced this pull request Jul 26, 2023

datacatalog - bump Taxonomy and PolicyTag to ga (GoogleCloudPlatform#…

c0ed306

…6989) * update Taxonomy and PolicyTag to ga * update Taxonomy and PolicyTag to ga * refactor * refactor

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

datacatalog - bump Taxonomy and PolicyTag to ga #6989

datacatalog - bump Taxonomy and PolicyTag to ga #6989

DrFaust92 commented Dec 18, 2022

modular-magician commented Dec 18, 2022

modular-magician commented Dec 18, 2022

modular-magician commented Dec 18, 2022

modular-magician commented Dec 18, 2022

modular-magician commented Dec 18, 2022

modular-magician commented Jan 1, 2023

modular-magician commented Jan 1, 2023

modular-magician commented Jan 1, 2023

melinath commented Jan 9, 2023 •

edited

Loading

melinath commented Jan 30, 2023

melinath left a comment

DrFaust92 commented Jan 30, 2023 via email

melinath commented Jan 30, 2023

DrFaust92 commented Jan 31, 2023

melinath commented Feb 2, 2023

melinath commented Feb 3, 2023

SarahFrench commented Feb 3, 2023

SarahFrench commented Feb 7, 2023

SarahFrench commented Feb 20, 2023

DrFaust92 commented Feb 25, 2023

DrFaust92 commented Feb 25, 2023

melinath commented Feb 27, 2023

modular-magician commented Feb 27, 2023

modular-magician commented Feb 27, 2023

modular-magician commented Feb 27, 2023

melinath left a comment

melinath commented Feb 27, 2023

melinath commented Feb 27, 2023

datacatalog - bump Taxonomy and PolicyTag to ga #6989

datacatalog - bump Taxonomy and PolicyTag to ga #6989

Conversation

DrFaust92 commented Dec 18, 2022

modular-magician commented Dec 18, 2022

modular-magician commented Dec 18, 2022

Diff report

modular-magician commented Dec 18, 2022

Diff report

modular-magician commented Dec 18, 2022

Tests analytics

Action taken

modular-magician commented Dec 18, 2022

modular-magician commented Jan 1, 2023

Diff report

modular-magician commented Jan 1, 2023

Tests analytics

Action taken

modular-magician commented Jan 1, 2023

melinath commented Jan 9, 2023 • edited Loading

melinath commented Jan 30, 2023

melinath left a comment

Choose a reason for hiding this comment

DrFaust92 commented Jan 30, 2023 via email

melinath commented Jan 30, 2023

DrFaust92 commented Jan 31, 2023

melinath commented Feb 2, 2023

melinath commented Feb 3, 2023

SarahFrench commented Feb 3, 2023

SarahFrench commented Feb 7, 2023

SarahFrench commented Feb 20, 2023

DrFaust92 commented Feb 25, 2023

DrFaust92 commented Feb 25, 2023

melinath commented Feb 27, 2023

modular-magician commented Feb 27, 2023

Diff report

modular-magician commented Feb 27, 2023

Tests analytics

Action taken

modular-magician commented Feb 27, 2023

melinath left a comment

Choose a reason for hiding this comment

melinath commented Feb 27, 2023

melinath commented Feb 27, 2023

melinath commented Jan 9, 2023 •

edited

Loading