Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gke gcsfuse #14546

Merged
merged 1 commit into from
May 9, 2023
Merged

Gke gcsfuse #14546

merged 1 commit into from
May 9, 2023

Conversation

modular-magician
Copy link
Collaborator

This PR is to add terraform support for running GCSFuse as CSI driver for GKE cluster.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

GKE: Add GCSFuse for GKE cluster.

Derived from GoogleCloudPlatform/magic-modules#7884

@modular-magician @megan07
Gke gcsfuse (hashicorp#7884)
c4f3842 
* Adding GCFuse addons attributes in GKE terraform resource.

* Fixing syntax error.

* Updating go.mud and go.sum files.

* Moving "gcp_filestore_csi_driver_config" to "ga" block to include it only in google-beta version.

* Update mmv1/third_party/terraform/website/docs/r/container_cluster.html.markdown

Co-authored-by: megan07 <[email protected]>

* Updating "gcs_fuse_csi_driver_config" location.

* Fixing the error and moving the right gcs_fuse_csi_driver_config attribute.

* Fixing spacing.

---------

Co-authored-by: megan07 <[email protected]>
Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit cbefbc3 into hashicorp:main May 9, 2023
@github-actions
Copy link

github-actions bot commented Jun 9, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 9, 2023
@modular-magician modular-magician deleted the downstream-pr-5e53b531a8f1c751dc0c303903a80f0eba99ae7d branch November 16, 2024 23:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@modular-magician