resource/random_password+random_string: Prevent override_special differences upgrading from 3.3.2 #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reference: #307 This change fixes the source of the `bcrypt_hash` generation to being the result of the random password generation. The issue was introduced in v3.4.0. Previously: ``` --- FAIL: TestAccResourcePassword_BcryptHash (0.63s) /Users/bflad/src/github.com/hashicorp/terraform-provider-random/internal/provider/resource_password_test.go:107: Step 1/1 error: Check failed: Check 3/3 error: crypto/bcrypt: hashedPassword is not the hash of the given password ``` Suggested CHANGELOG: ``` NOTES: * resource/random_password: If the resource was created between versions 3.4.0 and 3.4.2, the `bcrypt_hash` value will not correctly verify against the `result` value. Use `terraform taint` or `terraform apply -replace` to trigger resource recreation with this version. BUG FIXES: * resource/random_password: Fixed incorrect `bcrypt_hash` generation since version 3.4.0 ```
… from 3.3.2 Reference: #306 This fixes the `override_special` attribute issues by removing `Computed: true` and the empty string default value plan modifier (this attribute's value should always come from the practitioner) and resolves the underlying issue of always reading `plan.OverrideSpecial.Value` into the state, which will never be correct for null configurations. For any environment that happened to upgrade to 3.4.2 and save the empty string into state, the replacement plan modifier will allow in-place modification from empty string (`""`) to `null`. Previously after removing `Computed: true` and default value plan modifier: ``` === CONT TestAccResourcePassword_OverrideSpecial_FromVersion3_3_2 resource_password_test.go:221: Step 2/2 error: Error running apply: exit status 1 Error: Provider produced inconsistent result after apply When applying changes to random_password.test, provider "provider[\"registry.terraform.io/hashicorp/random\"]" produced an unexpected new value: .override_special: was null, but now cty.StringVal(""). This is a bug in the provider, which should be reported in the provider's own issue tracker. === CONT TestAccResourcePassword_OverrideSpecial_FromVersion3_4_2 resource_password_test.go:255: Step 2/2 error: Error running apply: exit status 1 Error: Provider produced inconsistent result after apply When applying changes to random_password.test, provider "provider[\"registry.terraform.io/hashicorp/random\"]" produced an unexpected new value: .override_special: was null, but now cty.StringVal(""). This is a bug in the provider, which should be reported in the provider's own issue tracker. ``` Previously before adjusting requires replace plan modifier: ``` === CONT TestAccResourcePassword_OverrideSpecial_FromVersion3_3_2 resource_password_test.go:221: Step 2/2 error: Check failed: Check 3/3 error: attribute values are different, got :i$(*K3_Vinv and FSw{$8sB#Uc3 === CONT TestAccResourcePassword_OverrideSpecial_FromVersion3_4_2 resource_password_test.go:255: Step 2/2 error: Check failed: Check 3/3 error: attribute values are different, got VrNYb]{#Z2Xu and XZD#_<BjDhkH ```
bendbennett
approved these changes
Sep 6, 2022
Co-authored-by: Benjamin Bennett <[email protected]>
…ial explicitly to null during import
Previously:
```
=== RUN TestAccResourcePassword
resource_password_test.go:67: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected.
(map[string]string) (len=1) {
(string) (len=16) "override_special": (string) ""
}
(map[string]string) {
}
--- FAIL: TestAccResourcePassword (0.79s)
```
1 task
This was referenced Sep 8, 2022
1 task
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #306
Builds on #308
Note: This was almost completed work from Friday, but I didn't have time to submit it. We should compare and contrast this with #310, which I'll take a look at now.
This fixes the
override_specialattribute issues by removingComputed: trueand the empty string default value plan modifier (this attribute's value should always come from the practitioner) and resolves the underlying issue of always readingplan.OverrideSpecial.Valueinto the state, which will never be correct for null configurations.For any environment that happened to upgrade to 3.4.2 and save the empty string into state, the replacement plan modifier will allow in-place modification from empty string (
"") tonull.Previously after removing
Computed: trueand default value plan modifier:Previously before adjusting requires replace plan modifier: