Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: validate backend configuration can't contain interpolations #12067

Merged
merged 1 commit into from
Feb 27, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 1 addition & 21 deletions config/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import (
"strings"

"github.com/hashicorp/go-multierror"
"github.com/hashicorp/go-version"
"github.com/hashicorp/hil"
"github.com/hashicorp/hil/ast"
"github.com/hashicorp/terraform/helper/hilmapstructure"
Expand Down Expand Up @@ -254,26 +253,7 @@ func (c *Config) Validate() error {

// Validate the Terraform config
if tf := c.Terraform; tf != nil {
if raw := tf.RequiredVersion; raw != "" {
// Check that the value has no interpolations
rc, err := NewRawConfig(map[string]interface{}{
"root": raw,
})
if err != nil {
errs = append(errs, fmt.Errorf(
"terraform.required_version: %s", err))
} else if len(rc.Interpolations) > 0 {
errs = append(errs, fmt.Errorf(
"terraform.required_version: cannot contain interpolations"))
} else {
// Check it is valid
_, err := version.NewConstraint(raw)
if err != nil {
errs = append(errs, fmt.Errorf(
"terraform.required_version: invalid syntax: %s", err))
}
}
}
errs = append(errs, c.Terraform.Validate()...)
}

vars := c.InterpolatedVariables()
Expand Down
57 changes: 57 additions & 0 deletions config/config_terraform.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
package config

import (
"fmt"
"strings"

"github.com/hashicorp/go-version"
"github.com/mitchellh/hashstructure"
)

Expand All @@ -11,6 +15,38 @@ type Terraform struct {
Backend *Backend // See Backend struct docs
}

// Validate performs the validation for just the Terraform configuration.
func (t *Terraform) Validate() []error {
var errs []error

if raw := t.RequiredVersion; raw != "" {
// Check that the value has no interpolations
rc, err := NewRawConfig(map[string]interface{}{
"root": raw,
})
if err != nil {
errs = append(errs, fmt.Errorf(
"terraform.required_version: %s", err))
} else if len(rc.Interpolations) > 0 {
errs = append(errs, fmt.Errorf(
"terraform.required_version: cannot contain interpolations"))
} else {
// Check it is valid
_, err := version.NewConstraint(raw)
if err != nil {
errs = append(errs, fmt.Errorf(
"terraform.required_version: invalid syntax: %s", err))
}
}
}

if t.Backend != nil {
errs = append(errs, t.Backend.Validate()...)
}

return errs
}

// Backend is the configuration for the "backend" to use with Terraform.
// A backend is responsible for all major behavior of Terraform's core.
// The abstraction layer above the core (the "backend") allows for behavior
Expand Down Expand Up @@ -46,3 +82,24 @@ func (b *Backend) Rehash() uint64 {

return code
}

func (b *Backend) Validate() []error {
if len(b.RawConfig.Interpolations) > 0 {
return []error{fmt.Errorf(strings.TrimSpace(errBackendInterpolations))}
}

return nil
}

const errBackendInterpolations = `
terraform.backend: configuration cannot contain interpolations

The backend configuration is loaded by Terraform extremely early, before
the core of Terraform can be initialized. This is necessary because the backend
dictates the behavior of that core. The core is what handles interpolation
processing. Because of this, interpolations cannot be used in backend
configuration.

If you'd like to parameterize backend configuration, we recommend using
partial configuration with the "-backend-config" flag to "terraform init".
`
7 changes: 7 additions & 0 deletions config/config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,13 @@ func TestConfigValidate_table(t *testing.T) {
false,
"",
},

{
"backend config with interpolations",
"validate-backend-interpolate",
true,
"cannot contain interp",
},
}

for i, tc := range cases {
Expand Down
5 changes: 5 additions & 0 deletions config/test-fixtures/validate-backend-interpolate/main.tf
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
terraform {
backend "foo" {
key = "${var.var}"
}
}