Add protobuf for provider-defined functions #34383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bflad
approved these changes
Dec 8, 2023
jbardin
force-pushed
the
jbardin/provider-functions-proto
branch
from
dde6b93 to
5c8fd0b
Compare
|
Already done ;) manual rebasing still in progress, so not all commits were lined up yet |
bflad
added a commit
to hashicorp/terraform-plugin-go
that referenced
this pull request
Dec 11, 2023
Reference: hashicorp/terraform#34383 The next version of the plugin protocol (5.5/6.5) includes support for provider defined functions. This change introduces the initial implementation of that support including: - Updated Protocol Buffers definitions - Re-generated Protocol Buffers Go code - Initial implementations of `tfprotov5` and `tfprotov6` package abstractions and wiring between those abstractions and the Protocol Buffers generated Go code - Initial implementations of `tfprotov5/tf5server` and `tfprotov6/tf6server` for the new `GetFunctions` and `CallFunction` RPCs Similar to the last set of protocol RPC changes, `ProviderServer` implementations must implement the new RPCs by either including function support or always returning an error. The HashiCorp-maintained provider development SDKs will receive updates to match this change.
bflad
added a commit
to hashicorp/terraform-plugin-go
that referenced
this pull request
Dec 14, 2023
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
bflad
added a commit
to hashicorp/terraform-plugin-go
that referenced
this pull request
Dec 14, 2023
#351) Reference: hashicorp/terraform#34383 Reference: #353 The next version of the plugin protocol (5.5/6.5) includes support for provider defined functions. This change introduces the initial implementation of that support including: - Updated Protocol Buffers definitions - Re-generated Protocol Buffers Go code - Initial implementations of `tfprotov5` and `tfprotov6` package abstractions and wiring between those abstractions and the Protocol Buffers generated Go code - Initial implementations of `tfprotov5/tf5server` and `tfprotov6/tf6server` for the new `GetFunctions` and `CallFunction` RPCs This temporarily will not require `ProviderServer` implementations to include `FunctionServer` implementation, however that change will occur in a subsequent release.
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add init protocol definitions 5.5 and 6.5, containing the addition of provider-defined functions.
This PR only updates the protobuf definitions to include provider defined functions messages and calls, along with the files generated from the protocol.