OpenAPI: Sort parameters for stable output #22043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In my recent hashicorp#21942, I overlooked the need to sort another part of the OpenAPI document to ensure stable output. I've also removed `strings.ToLower()` from the code I copied from, as this code is sorting Vault API parameter names, which are all lowercase anyway!
|
Requesting |
This was referenced Jul 25, 2023
Closed
averche
pushed a commit
to hashicorp/vault-client-go
that referenced
this pull request
Jul 25, 2023
* hashicorp/vault#21934 - a standard response structure is applied to all list operations that do not explicitly override it * hashicorp/vault#22043 - query parameters will now appear as method parameters in alphabetic order, rather than at the whims of Go map iteration order
averche
pushed a commit
to hashicorp/vault-client-dotnet
that referenced
this pull request
Jul 25, 2023
Sync OpenAPI: StandardListResponse & sorted query parameters * hashicorp/vault#21934 - a standard response structure is applied to all list operations that do not explicitly override it * hashicorp/vault#22043 - query parameters will now appear as method parameters in alphabetic order, rather than at the whims of Go map iteration order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my recent #21942, I overlooked the need to sort another part of the
OpenAPI document to ensure stable output.
I've also removed
strings.ToLower()from the code I copied from, asthis code is sorting Vault API parameter names, which are all lowercase
anyway!