Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin backends docs #3125

Merged
merged 4 commits into from
Aug 8, 2017
Merged

Add plugin backends docs #3125

merged 4 commits into from
Aug 8, 2017

Conversation

calvn
Copy link
Contributor

@calvn calvn commented Aug 8, 2017

No description provided.

@calvn calvn requested a review from jefferai August 8, 2017 02:06

## Unmount the plugin

```shell
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking this as shell does some weird highlighting like on false and local. I'd just leave it as text or as nothing. (Elsewhere too.)

operates under the same underlying plugin mechanism, it is slightly different
in design than plugin backends demonstrated in this guide. The database backend
manages multiple plugins under the same backend mount point, whereas plugin
backends are generic backends that functions as either a secret or auth backend.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/functions/function, also s/either a secret or auth backends/either secret or auth backends

Copy link
Member

@jefferai jefferai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a couple comments, I think this is fine. We can always spruce it up more at any point.


This guide provides steps to build, register, and mount non-database external
plugin backends.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somewhere we need to mention that reading the original connection's TLS connection state is not supported in plugins.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll mention this on the plugin internals page.

@calvn calvn merged commit ffc7901 into master Aug 8, 2017
@calvn calvn deleted the plugin-docs branch August 8, 2017 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants