Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

Snapshot/Restore APIs #723

Merged
merged 22 commits into from
Nov 2, 2020
Merged

Snapshot/Restore APIs #723

merged 22 commits into from
Nov 2, 2020
+3,837 −1,145

Conversation

mitchellh
Copy link
Contributor

@mitchellh mitchellh commented Oct 29, 2020 •
edited
Loading

Details are in RFC WP-039.

This is only the APIs to implement snapshot/restore. I'll implement the CLI in a future PR.

Importantly, the restore is a stage restore operation currently and not a full online restore. It requires the server to be restarted to complete the restore.

@mitchellh
internal/server: proto CreateSnapshot
7160344
@mitchellh
internal/server: CreateSnapshot API
b6043ea
@mitchellh
internal/server/state: snapshot/restore
746dc96
@mitchellh
go.mod
9c5755f
@mitchellh
internal/server/state: test snapshot/restore
44a768f
@mitchellh
internal/server/state: validate restore file consistency
f712deb
@mitchellh
internal/server/state: validate that restore only happens once
12879a1
@mitchellh
internal/server/state: snapshot/restore should use db-agnostic format
8278715
@mitchellh
internal/server/proto: trailers for snapshot
a48b5c2
@mitchellh
internal/server: calculate checksum and add as a trailer
70eb22a 
Reader currently ignores this.
@mitchellh
internal/server/state: validate checksum on restore
2a46f05
@mitchellh
internal/server: do not forget to close gzip reader
c94ce71
@mitchellh
internal/server/state: during snapshot restore, txn should be smaller
15a91eb 
bolt holds all data in memory during a txn so we need to make these
smaller
@mitchellh
internal/server/proto: restore
a656b84
@mitchellh
internal/server: RestoreSnapshot impl, no tests yet
5d0529e
@mitchellh
internal/server: snapshot/restore unit test
e91f090
@github-actions github-actions bot added the core label Oct 29, 2020
@mitchellh mitchellh added this to the 0.2.0 milestone Oct 29, 2020
evanphx
evanphx suggested changes Oct 30, 2020
View reviewed changes
Copy link
Contributor

@evanphx evanphx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor thing about the naming of the last chunk before the trailer.

internal/server/proto/server.proto Outdated Show resolved Hide resolved
@mitchellh mitchellh requested a review from evanphx October 30, 2020 18:17
briancain
briancain approved these changes Nov 2, 2020
View reviewed changes
Copy link
Member

@briancain briancain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just left a few open questions around a few log messages to ease some debugging woes in the future, but I don't think they should block merge if the changes don't make sense 👍

internal/server/singleprocess/state/snapshot.go Outdated Show resolved Hide resolved
internal/server/singleprocess/state/snapshot.go Outdated Show resolved Hide resolved
internal/server/singleprocess/state/snapshot.go Outdated Show resolved Hide resolved
@mitchellh mitchellh merged commit 6895d60 into main Nov 2, 2020
@mitchellh mitchellh deleted the f-snapshot branch November 2, 2020 23:57
@mitchellh mitchellh mentioned this pull request Nov 2, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@briancain briancain briancain approved these changes

@krantzinator krantzinator Awaiting requested review from krantzinator

@evanphx evanphx Awaiting requested review from evanphx

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mitchellh @evanphx @briancain