Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

antsi: remove const trait implementations #2522

Merged
merged 1 commit into from
May 8, 2023
Merged

Conversation

indietyp
Copy link
Member

@indietyp indietyp commented May 8, 2023

🌟 What is the purpose of this PR?

This removes the const From implementations from the antsi codebase, due to rust-lang/rust#110395. For now, this drastically impacts ergonomics of using the crate, but is a stop-gap solution until a better one is found.

🔗 Related links

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • modifies a Cargo-publishable library, but it is not yet ready to publish

📜 Does this require a change to the docs?

The changes in this PR:

  • is in a state where docs changes are not yet required but will be

🕸️ Does this require a change to the Turbo Graph?

The changes in this PR:

  • does not affect the execution graph

⚠️ Known issues

🐾 Next steps

🛡 What tests cover this?

❓ How to test this?

  1. Checkout the branch / view the deployment
  2. Try X
  3. Confirm that Y

📹 Demo

@indietyp indietyp requested a review from a team as a code owner May 8, 2023 09:59
@github-actions github-actions bot added the area/libs > antsi Affects the `antsi` crate (library) label May 8, 2023
@indietyp indietyp requested a review from TimDiekmann May 8, 2023 10:00
@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Attention: Patch coverage is 0% with 40 lines in your changes missing coverage. Please review.

Project coverage is 55.66%. Comparing base (76b2c75) to head (4700af7).
Report is 2960 commits behind head on main.

Files with missing lines Patch % Lines
libs/antsi/src/lib.rs 0.00% 24 Missing ⚠️
libs/antsi/src/color.rs 0.00% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2522      +/-   ##
==========================================
- Coverage   55.68%   55.66%   -0.03%     
==========================================
  Files         332      331       -1     
  Lines       26863    26875      +12     
  Branches      453      453              
==========================================
  Hits        14959    14959              
- Misses      11899    11911      +12     
  Partials        5        5              
Flag Coverage Δ
antsi 0.35% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@TimDiekmann TimDiekmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

At least the code is more readable 😄

@indietyp indietyp enabled auto-merge May 8, 2023 10:07
@indietyp indietyp added this pull request to the merge queue May 8, 2023
Merged via the queue into main with commit ff48a35 May 8, 2023
@indietyp indietyp deleted the bm/antsi/fix-const branch May 8, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/libs > antsi Affects the `antsi` crate (library)
Development

Successfully merging this pull request may close these issues.

2 participants