Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore doc-snapshot outputs on non-nightly compiler #2528

Merged
merged 1 commit into from
May 8, 2023

Conversation

TimDiekmann
Copy link
Member

🌟 What is the purpose of this PR?

The line-number in doc-test changed in a recent nightly compiler version so the lines do not align on 1.65 and the current nightly compiler. This only runs the snapshot tests on a nightly toolchain. There are still plenty of tests, which are covered on the stable toolchain.

🔗 Related links

🔍 What does this change?

  • Only run doc-snapshot tests on nightly

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • modifies a Cargo-publishable library, but it is not yet ready to publish

📜 Does this require a change to the docs?

The changes in this PR:

  • does not require a docs change

🕸️ Does this require a change to the Turbo Graph?

The changes in this PR:

  • does not affect the execution graph

@TimDiekmann TimDiekmann requested a review from indietyp May 8, 2023 13:37
@TimDiekmann TimDiekmann requested a review from a team as a code owner May 8, 2023 13:37
@github-actions github-actions bot added the area/libs > error-stack Affects the `error-stack` crate (library) label May 8, 2023
@TimDiekmann TimDiekmann changed the title Ignore snapshot outputs on non-nightly compiler Ignore doc0snapshot outputs on non-nightly compiler May 8, 2023
@TimDiekmann TimDiekmann changed the title Ignore doc0snapshot outputs on non-nightly compiler Ignore doc-snapshot outputs on non-nightly compiler May 8, 2023
@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 55.66%. Comparing base (c794800) to head (1caf10d).
Report is 2953 commits behind head on main.

Files with missing lines Patch % Lines
libs/error-stack/src/fmt/hook.rs 0.00% 7 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2528   +/-   ##
=======================================
  Coverage   55.66%   55.66%           
=======================================
  Files         331      331           
  Lines       26875    26875           
  Branches      453      453           
=======================================
  Hits        14959    14959           
  Misses      11911    11911           
  Partials        5        5           
Flag Coverage Δ
error-stack 82.56% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TimDiekmann TimDiekmann added this pull request to the merge queue May 8, 2023
Merged via the queue into main with commit 3491e4e May 8, 2023
@TimDiekmann TimDiekmann deleted the td/error-stack/rust-1.65 branch May 8, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/libs > error-stack Affects the `error-stack` crate (library)
Development

Successfully merging this pull request may close these issues.

2 participants