Add instances for Data.Monoid #1101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phadej
reviewed
Jun 4, 2024
phadej
reviewed
Jun 4, 2024
AliceRixte
force-pushed
the
monoid-instances
branch
from
570dd35
to
806a832
Compare
AliceRixte
force-pushed
the
monoid-instances
branch
from
806a832
to
afe5ae3
Compare
phadej
reviewed
Jun 9, 2024
|
|
||
| liftParseJSONList _ _ p a = coerce (p a) |
There was a problem hiding this comment.
I added it back, and made it coherent with the rest of the code
There was a problem hiding this comment.
I also think it would make sense that these two lines
parseJSONList = liftParseJSONList omittedField parseJSON parseJSONList
omittedField = omittedField1
should be added to all the FromJSON instances from Data.Monoid. They were initially there in the First and Last and WrappedMonoid instances, but not in the Down instance. If you agree I can do this.
|
To make this easier I made #1104 So now the instances are simply using |
|
Pretty neat ! It was simpler for me to create a new pull request rather than cleaning up this one. Thanks a lot ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of Data.Monoid newtypes already had an instance. I added the following ones :