Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fullstops ( . ) in the README.md files close #9866 #9867

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mohitsooonni
Copy link

@mohitsooonni mohitsooonni commented Sep 4, 2023

Adding necessary periods ( . ) to improve code readability in the README.md file. This simple change enhances code clarity and adheres to coding conventions, benefiting both current and future developers. Attention to detail in punctuation ensures a smoother collaboration and better project maintainability.

Description

Changelog

Component : server / cli / console / build

Type: bugfix / feature / enhancement

Product: community-edition

Short Changelog

Long Changelog

Related Issues

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

Server checklist

Catalog upgrade

Does this PR change Hasura Catalog version?

  • No
  • Yes
    • Updated docs with SQL for downgrading the catalog

Metadata

Does this PR add a new Metadata feature?

  • No
  • Yes
    • Does run_sql auto manages the new metadata through schema diffing?
      • Yes
      • Not required
    • Does run_sql auto manages the definitions of metadata on renaming?
      • Yes
      • Not required
    • Does export_metadata/replace_metadata supports the new metadata added?
      • Yes
      • Not required

GraphQL

  • No new GraphQL schema is generated
  • New GraphQL schema is being generated:
    • New types and typenames are correlated

Breaking changes

  • There are breaking changes:

    1. Metadata API

      Existing query types:

      • Modify args payload which is not backward compatible
      • Behavioural change of the API
      • Change in response JSON schema
      • Change in error code
    2. GraphQL API

      Schema Generation:

      • Change in any NamedType
      • Change in table field names

      Schema Resolve:-

      • Change in treatment of null value for any input fields
    3. Logging

      • Log JSON schema has changed
      • Log type names have changed
  • No Breaking changes

Adding necessary periods ( . ) to improve code readability in the README.md file. This simple change enhances code clarity and adheres to coding conventions, benefiting both current and future developers. Attention to detail in punctuation ensures a smoother collaboration and better project maintainability.
@mohitsooonni mohitsooonni requested a review from a team as a code owner September 4, 2023 13:12
@hasura-bot
Copy link
Contributor

Beep boop! 🤖

Hey @mohitsooonni, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible.

Stay awesome! 😎

@mohitsooonni mohitsooonni changed the title Added fullstops ( . ) in the README.md files #9866 Added fullstops ( . ) in the README.md files close #9866 Sep 4, 2023
@CLAassistant
Copy link

CLAassistant commented Sep 4, 2023

CLA assistant check
All committers have signed the CLA.

@mohitsooonni mohitsooonni deleted the patch-1 branch September 6, 2023 07:21
@mohitsooonni mohitsooonni restored the patch-1 branch September 6, 2023 07:21
@mohitsooonni mohitsooonni reopened this Sep 6, 2023
@Stefmore02 Stefmore02 added the c/community Related to community content label Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/community Related to community content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants