-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev 922 dockerize #3
Conversation
- Copy required files from `ruby_github_actions_template` repo.
Summary of setup under Docker
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see no reason to hold this back. Most of my comments are minor.
A PR like this could benefit from having the different kinds of changes grouped into different commits, so that there's one commit with the actual payload, one with the tests, one with the standardrb, and so on. Makes it easier to navigate the changes. Way easier said than done, though. Just something I want to think more about, and maybe I'll have something more useful to say.
APPROVE.
DEV-922 add tests and containerization for hathifiles-database
ruby_github_actions_template
repo..gitignore
update for SimpleCov and rspec_status.Test coverage is still low, but what is there is non-trivial so I believe that acceptance criterion is met.
For Reviewers:
I would like a test of the clone, setup, test incantations. There is an awful lot of noise in the "files changed"-centric approach to reviewing.
Most of the changes fall into these categories:
standardrb --fix
results.require "hathifiles_database/constants"
instead ofinclude
: some added namespace verbosity. (This may be something that should be revisited in this PR.)