Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev 922 dockerize #3

Merged
merged 14 commits into from
Oct 30, 2023
Merged

Dev 922 dockerize #3

merged 14 commits into from
Oct 30, 2023

Conversation

moseshll
Copy link
Contributor

@moseshll moseshll commented Oct 20, 2023

DEV-922 add tests and containerization for hathifiles-database

  • Copy required files from ruby_github_actions_template repo.
  • .gitignore update for SimpleCov and rspec_status.
  • Appease Standardrb.
  • Begin expanding test coverage.

Test coverage is still low, but what is there is non-trivial so I believe that acceptance criterion is met.

For Reviewers:
I would like a test of the clone, setup, test incantations. There is an awful lot of noise in the "files changed"-centric approach to reviewing.

Most of the changes fall into these categories:

  • Mostly boilerplate Docker and CI additions.
  • standardrb --fix results.
  • Side effect of require "hathifiles_database/constants" instead of include: some added namespace verbosity. (This may be something that should be revisited in this PR.)
  • Added specs

@moseshll moseshll marked this pull request as draft October 20, 2023 19:27
@moseshll moseshll marked this pull request as ready for review October 27, 2023 16:02
Summary of setup under Docker
@moseshll moseshll requested a review from mwarin October 27, 2023 17:43
@mwarin
Copy link

mwarin commented Oct 27, 2023

lib/hathifiles_database/db/writer.rb and lib/hathifiles_database/db/connection.rb could do with a bit more test coverage.
Not that I think the numbers themselves are something to quibble over, but they appear to have important-looking methods uncovered.

Copy link

@mwarin mwarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no reason to hold this back. Most of my comments are minor.

A PR like this could benefit from having the different kinds of changes grouped into different commits, so that there's one commit with the actual payload, one with the tests, one with the standardrb, and so on. Makes it easier to navigate the changes. Way easier said than done, though. Just something I want to think more about, and maybe I'll have something more useful to say.

APPROVE.

README.md Show resolved Hide resolved
.github/workflows/build-manual.yml Show resolved Hide resolved
hathifiles_database.gemspec Outdated Show resolved Hide resolved
spec/exceptions_spec.rb Show resolved Hide resolved
@moseshll moseshll merged commit 186bf41 into main Oct 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants