HT-3038: Individual etas reports #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aelkiss
approved these changes
Jul 23, 2021
There was a problem hiding this comment.
Looks good to me; definitely glad to see specs added here. If performance is still lacking, it would probably be worth doing some profiling to verify where the issues are. I'm not seeing any obvious problems where it's iterating over the cluster multiple times unnecessarily. I do wonder how well missed_holdings will perform, but at least we're only calling it once per cluster.
mwarin
reviewed
Aug 2, 2021
mwarin
reviewed
Aug 2, 2021
mwarin
approved these changes
Aug 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version only produced records for holdings that matched HT Items. This version has at least one record for every holding.