HT-3072 add narrative and stat tracking to estimate generation #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwarin
approved these changes
Jul 27, 2021
|
|
||
| File.open(ocn_file).each do |line| | ||
| ocn = line.to_i | ||
| ocns << ocn | ||
| waypoint.incr | ||
|
|
||
| # Find a cluster | ||
| cluster = Cluster.find_by(ocns: ocn.to_i, |
There was a problem hiding this comment.
ocn has already been to_i'd on line 36.
There was a problem hiding this comment.
This comment pertains to "ocn.to_i" on line 41. I must have clicked wrong.
aelkiss
approved these changes
Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to the IC cost, this adds information about the number of unique OCNs and the count/percent of matches. In the old system we also reported the number of usable holdings (MPM, SPM, SER), but that is not readily available to
bin/compile_estimated_IC_costs.rbbecause it is only given a list of OCNs.