Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix add print holdings loader #118

Merged
merged 4 commits into from
Aug 30, 2021
Merged

Fix add print holdings loader #118

merged 4 commits into from
Aug 30, 2021

Conversation

mwarin
Copy link
Contributor

@mwarin mwarin commented Aug 30, 2021

No description provided.

aelkiss
aelkiss approved these changes Aug 30, 2021
View reviewed changes
Copy link
Member

@aelkiss aelkiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jsteverman
Copy link
Contributor

spec/add_print_holdings_spec.rb should probably be spec/loader/add_print_holdings_spec.rb

@mwarin mwarin merged commit 72d7653 into master Aug 30, 2021
@aelkiss aelkiss deleted the fix-add-print-holdings-loader branch September 2, 2021 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aelkiss aelkiss aelkiss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mwarin @jsteverman @aelkiss