HT-3118: Namespace services #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the following external sources of data to DataSources module: - HoldingsDB (mariadb) - HTCollections (mariadb) - HTMembers (mariadb) - LargeClusters (file) - SerialsFile (file)
- appease rubocop - remove separately-declared module
|
You may wish to view the changes as: (first commit) b8a110c (second commit, hiding whitespace changes): f56541f?diff=unified&w=1 |
jsteverman
approved these changes
Sep 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I chose the name
DataSources, since each of the moved things represents a source of data external to the application. The first commit makes the logical change and should be reasonably readable; the second changes indentation to appease rubocop so looks like a larger change than it is.