Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HT-3082: Compute item format using only HTItem #123

Merged
merged 1 commit into from
Sep 10, 2021
Merged

HT-3082: Compute item format using only HTItem #123

merged 1 commit into from
Sep 10, 2021

Conversation

aelkiss
Copy link
Member

@aelkiss aelkiss commented Sep 2, 2021 •
edited
Loading

  • use bib_fmt = 'SE' to detect serials
  • remove SerialsFile
  • Add traits to ht_item factory for constructing items of expected type
  • default to 0 for various counts to fix mysql warning

@aelkiss
Copy link
Member Author

aelkiss commented Sep 2, 2021

I will build an image from this branch and run a cost report using it; then we can compare what difference it makes.

@aelkiss aelkiss force-pushed the HT-3082-bibformat-serial branch from dcaf174 to ab81ab5 Compare September 2, 2021 15:27
@aelkiss aelkiss marked this pull request as ready for review September 7, 2021 20:52
jsteverman
jsteverman approved these changes Sep 7, 2021
View reviewed changes
Copy link
Contributor

@jsteverman jsteverman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am very happy to see the serials file go. I don't know where the bib_fmt: "s", "m", "r" came from which gives me some pause, but it might have just been a mistake.

@aelkiss
HT-3082: Compute item format using only HTItem
32b2b79 
- use bib_fmt = 'SE' to detect serials
- remove SerialsFile
- Add traits to ht_item factory for constructing items of expected type
- use 0 by default for copy count - fixes potential mysql warning with
counts for serials

Fixup
@aelkiss aelkiss force-pushed the HT-3082-bibformat-serial branch from ab81ab5 to 32b2b79 Compare September 8, 2021 13:24
@aelkiss aelkiss merged commit 7957048 into master Sep 10, 2021
@aelkiss aelkiss deleted the HT-3082-bibformat-serial branch September 10, 2021 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsteverman jsteverman jsteverman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aelkiss @jsteverman