Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding member_counts_report code (HT-2568). #126

Merged
merged 4 commits into from
Sep 9, 2021
Merged

Adding member_counts_report code (HT-2568). #126

merged 4 commits into from
Sep 9, 2021

Conversation

mwarin
Copy link
Contributor

@mwarin mwarin commented Sep 2, 2021

No description provided.

@mwarin mwarin requested review from jsteverman and aelkiss September 2, 2021 16:37
aelkiss
aelkiss requested changes Sep 3, 2021
View reviewed changes
Copy link
Member

@aelkiss aelkiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overall shape & tests look good, but there are a few specific changes I'd like to see:

  • move logic from bin/reports/compile_member_counts/report.rb to lib/report/member_counts_report
  • fix bin/reports vs lib/report
  • define total_loaded, distinct_ocns matching_volumes as attributes on MemberCountsRow
  • consider consistently using spm / mpm / ser vs. mono / multi / serial

bin/reports/compile_member_counts_report.rb Show resolved Hide resolved
lib/report/member_counts_report.rb Outdated Show resolved Hide resolved
lib/report/member_counts_report.rb Outdated Show resolved Hide resolved
lib/report/member_counts_report.rb Outdated Show resolved Hide resolved
lib/report/member_counts_report.rb Outdated Show resolved Hide resolved
spec/report/member_counts_report_spec.rb Outdated Show resolved Hide resolved
spec/report/member_counts_report_spec.rb Outdated Show resolved Hide resolved
lib/report/member_counts_report.rb Outdated Show resolved Hide resolved
aelkiss
aelkiss approved these changes Sep 7, 2021
View reviewed changes
Copy link
Member

@aelkiss aelkiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine. I can look and see tomorrow what's going on with the reported merge conflict.

jsteverman
jsteverman approved these changes Sep 7, 2021
View reviewed changes
lib/report/cost_report.rb Outdated Show resolved Hide resolved
@mwarin mwarin merged commit 1780fb0 into master Sep 9, 2021
@aelkiss aelkiss deleted the HT-2568-member-counts-report branch October 1, 2021 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsteverman jsteverman jsteverman approved these changes

@aelkiss aelkiss aelkiss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mwarin @jsteverman @aelkiss