Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HT-2909: Remove Kubernetes stuff #144

Merged
merged 1 commit into from
Nov 5, 2021
Merged

HT-2909: Remove Kubernetes stuff #144

merged 1 commit into from
Nov 5, 2021

Conversation

aelkiss
Copy link
Member

@aelkiss aelkiss commented Oct 27, 2021

@aelkiss
Copy link
Member Author

aelkiss commented Oct 27, 2021

Need to update documentation referencing this before merging.

@aelkiss aelkiss marked this pull request as draft October 27, 2021 13:35
@aelkiss aelkiss force-pushed the HT-2909-k8s-cleanup branch from fd15f54 to 71ad6d8 Compare November 1, 2021 15:38
@aelkiss aelkiss marked this pull request as ready for review November 1, 2021 15:46
@aelkiss
Copy link
Member Author

aelkiss commented Nov 1, 2021

See especially changes to this file: https://github.com/hathitrust/holdings-backend/blob/HT-2909-k8s-cleanup/routine_tasks.md

I'm interested in feedback on whether we should move this file to Confluence -- I am leaning towards doing that as it references things beyond this repository including a lot of internal paths, people & configuration

@aelkiss aelkiss requested review from jsteverman and mwarin November 1, 2021 15:53
* Get the file(s) you want from `/htapps/mwarin.babel/phdb_scripts/data/loadfiles/`
* Add UUIDs for tracking whether the individual line has been processed: `bin ruby/add_uuid.rb infile > outfile`
* `docker-compose run --rm dev bundle exec bin/add_print_holdings.rb outfile`



## K8s Cronjob
`kubectl create -f cron_job.yaml`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OT: I don't think this ever made it from the old concordance repo to holdings-backend. The cronjob in ht_tanka remains commented out. https://github.com/hathitrust/ht_tanka/pull/9/files#diff-d37db7a43061041cef4bba8b70897d4bdaa3b8675e491a31c89a56a395295de6

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks -- I was wondering where that ended up. I was thinking we were waiting to re-enabled it until we fully automate the whole process -- do we want it enabled now?

@jsteverman jsteverman self-requested a review November 1, 2021 18:43
@jsteverman
Copy link
Contributor

See especially changes to this file: https://github.com/hathitrust/holdings-backend/blob/HT-2909-k8s-cleanup/routine_tasks.md

I'm interested in feedback on whether we should move this file to Confluence -- I am leaning towards doing that as it references things beyond this repository including a lot of internal paths, people & configuration

I agree, it should be moved to Confluence.

- k8s stuff moved to https://github.com/hathitrust/ht_tanka
- documentation moved to confluence
@aelkiss aelkiss force-pushed the HT-2909-k8s-cleanup branch from 71ad6d8 to dca8206 Compare November 2, 2021 17:05
@aelkiss aelkiss merged commit d535309 into main Nov 5, 2021
@aelkiss aelkiss deleted the HT-2909-k8s-cleanup branch November 5, 2021 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants