Clusterable Shared Print Commitments and loader #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Agreed, we should not update |
aelkiss
reviewed
Nov 19, 2021
There was a problem hiding this comment.
This all looks good to me and in-line with what we're doing with other data types. I think we can go ahead and merge once the last_updated thing is taken care of. It would be useful to have feedback from @mwarin before going too much farther, but I think we can proceed for now.
mwarin
reviewed
Nov 29, 2021
mwarin
reviewed
Nov 29, 2021
mwarin
reviewed
Nov 29, 2021
|
|
||
| RSpec.describe Loader::SharedPrintLoader do | ||
| let(:json) do | ||
| '{"uuid":"e78047da-1193-43c7-aab0-492067d13f9c","organization":"ucsd","ocn":2, |
There was a problem hiding this comment.
Break out and put in spec/fixtures/ ?
mwarin
approved these changes
Nov 29, 2021
jsteverman
force-pushed
the
HT-3228-sharedprint-class
branch
from
8e480ba to
8d99eff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't address updates or deprecations, or even identity (there are a lot of duplicates in the existing database).
My only concern before loading is the setting of
cluster.last_modifiedwhen adding commitments, which seems unnecessary.