Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove logging to slack #152

Merged
merged 2 commits into from
Dec 14, 2021
Merged

Remove logging to slack #152

merged 2 commits into from
Dec 14, 2021

Conversation

aelkiss
Copy link
Member

@aelkiss aelkiss commented Dec 13, 2021

With logging via Loki and alerting via the pushgateway, there isn't as much need for this.

I waffled a bit as to whether to remove MultiLogger and SlackWriter entirely, but I think it makes sense to do so for a couple reasons:

  1. there's no current need for it
  2. if we have a need for this in the future we can use loki and alertmanager to selectively alert based on certain things being logged
  3. we can revert later if need be if we have a scenario where we want to send things to slack outside of normal logging/alerting

With logging via Loki and alerting via the pushgateway, there isn't as
much need for this.
@aelkiss aelkiss requested review from jsteverman and mwarin December 13, 2021 16:08
@aelkiss aelkiss merged commit 3e7b649 into main Dec 14, 2021
@aelkiss aelkiss deleted the disable-slack-logging branch December 14, 2021 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants