delete specified holdings and any empty clusters that result #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsteverman
reviewed
Dec 14, 2021
jsteverman
reviewed
Dec 14, 2021
|
I think it would benefit from some documentation to indicate how to use this. |
jsteverman
approved these changes
Dec 17, 2021
aelkiss
reviewed
Dec 17, 2021
aelkiss
reviewed
Dec 17, 2021
There was a problem hiding this comment.
I think it would make sense to at least split out option parsing from the actual deletion (e.g. HoldingsDeleter should get a pre-parsed set of criteria).
While I agree OptionParser would simplify this I don't know if we need to do it right now if this works -- eventually I think we should consider a common CLI front-end for all our various scripts (thor is the most popular, but there are a couple other options e.g. gli)
mwarin
force-pushed
the
pull-delete-holdings
branch
from
7fba386 to
652a3e4
Compare
|
Replaced homemade option parsing with optparse and squashed commits. |
jsteverman
approved these changes
Jan 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.