Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New class Utils::SessionKeepAlive: for keeping sessions alive #156

Merged
merged 1 commit into from
Jan 17, 2022

Conversation

mwarin
Copy link
Contributor

@mwarin mwarin commented Jan 7, 2022

Broke out some code from lib/overlap/overlap_table_update.rb into new class lib/utils/session_keep_alive.rb, since the same thing was needed to keep the holdings deleter from crashing with an expired cursor.

@jsteverman and I tried to think what a (useful && non-production) test for this would look like. overlap_table_update.rb does not directly test this behavior.

Any ideas from @aelkiss or the Universe appreciated.

@mwarin mwarin requested a review from aelkiss January 7, 2022 18:32
@aelkiss
Copy link
Member

aelkiss commented Jan 7, 2022

After looking a bit, I'd suggest:

@mwarin mwarin changed the title New class Utils::SessionKeepAlive: for keeping sessions alive, needs tests. New class Utils::SessionKeepAlive: for keeping sessions alive Jan 14, 2022
@mwarin mwarin force-pushed the holdings-deleter-fix-01 branch from f71f978 to fdae0f2 Compare January 14, 2022 17:34
@mwarin mwarin marked this pull request as ready for review January 14, 2022 17:37
@mwarin mwarin requested a review from jsteverman January 14, 2022 17:37
Copy link
Contributor

@jsteverman jsteverman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@mwarin mwarin merged commit fe7742a into main Jan 17, 2022
@aelkiss aelkiss deleted the holdings-deleter-fix-01 branch February 8, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants