Validate gzip AND txt files found in conc/raw #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aelkiss
reviewed
Jan 10, 2022
| @@ -25,9 +25,9 @@ def review_logs(log_file) | |||
|
|
|||
| conc_dir = Settings.concordance_path | |||
|
|
|||
| raw_gzip_files = Dir.glob("#{conc_dir}/raw/*txt.gz").sort | |||
| raw_files = Dir.glob("#{conc_dir}/raw/*txt*").sort | |||
There was a problem hiding this comment.
Any concerns about this matching e.g. "this_is_not_a_txt_file"? I figure we control what goes in that directory, so it shouldn't be a big issue?
There was a problem hiding this comment.
No more than it matching "junk_that_shouldnt_be_in_this_directory.txt.gz". If it gets garbage it will end up erroring out anyway.
aelkiss
reviewed
Jan 10, 2022
|
|
||
| file_names_split = raw_gzip_files.map {|fname| fname.split("/").last.split("_").first } | ||
| file_names_split = raw_files.map {|fname| fname.split("/").last.split("_").first } | ||
| raw_dates = file_names_split.select {|d| d =~ /^\d+$/ } |
There was a problem hiding this comment.
Might be more clear here to use a regex here -- if nothing else, it would be worth a comment here as to what filename format this is expecting.
There was a problem hiding this comment.
Commented expected file format.
There was a problem hiding this comment.
And now with regex instead of split("_").first
mwarin
approved these changes
Jan 10, 2022
jsteverman
force-pushed
the
validate-and-delta-txt-and-gzip
branch
from
41fa652 to
4c6dfe9
Compare
jsteverman
force-pushed
the
validate-and-delta-txt-and-gzip
branch
from
4c6dfe9 to
665645d
Compare
aelkiss
approved these changes
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.