dealing with holdings on large clusters #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwarin
force-pushed
the
202305-large-cluster
branch
from
4fdd39b to
a025938
Compare
moseshll
approved these changes
Jun 2, 2023
There was a problem hiding this comment.
FYI I had only one problem with this (and I think maybe I have seen this before so it's not related to the PR and should not be an impediment):
The mongo_dev service in docker-compose.yml has two volumes entries, on my Macs this causes docker-compose build to gripe
parsing /Users/moseshll/hathitrust/holdings-backend/docker-compose.yml: yaml: unmarshal errors:
line 41: mapping key "volumes" already defined at line 38
The easy fix was just to combine the two volumes entries and tally-ho.
mwarin
force-pushed
the
202305-large-cluster
branch
from
75de9b3 to
b9bff9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to understand/prevent/fix the issue of super bloated holdings on large clusters.
Contains some new tests and a bin script that forces the specified clusters to behave as
LargeClusters(i.e. max one holding per org).