Dev-550: (bugfix) Making sure variable is used properly in query

[mwarin]

Diff, essentially:

- w
+ W

That is to say, what has functionally changed is a non-interpolating %w[...] was changed into an interpolating %W[...]. The changed code was broken out into its own method (query) so I could write a simple test to make it obvious that interpolation happened.

[coveralls]

coverage: 95.137% (-0.02%) from 95.159% when pulling 563faef on DEV-550-bugfix into e1261a5 on main.

[aelkiss]

A couple thoughts: while this appears correct, it's an unusual construction (I don't know that I've ever seen %W before) and is insecure - given that start_date is passed in from the outside this is in theory vulnerable to sql injection. Best practice is to use a SQL placeholder for start_date. If we want a multi-line string I would prefer using a heredoc (mariadb shouldn't care about the extra whitespace):

QUERY = <<~SQL
        SELECT
        CONCAT(namespace, '.', id) AS ht_id,
        MIN(DATE_FORMAT(time, "%Y-%m-%d")) AS min_time
        FROM
        rights_log
        GROUP BY
        namespace, id
        HAVING
        MIN(time) >= ?
SQL

along with:

  db.fetch(QUERY,@start_date) do |row|
    ...
  end

(see https://www.rubydoc.info/gems/sequel/4.38.0/Sequel%2FDatabase:fetch)

[aelkiss]

Looks good now - thanks

[moseshll]

Three cheers for here docs.