DEV-779: weeding decision report #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwarin
force-pushed
the
DEV-779
branch
2 times, most recently
from
95327d3 to
c89c5f3
Compare
moseshll
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the new Weeding Decision report to the reports that can be started via
phctl.The Weeding Decision Report is mainly for use by shared print members, so this is something they would request from us to run and upload on their behalf.
The main query is based on a member's holdings, restricted to clusters with (1+ open) items and (1+ non-deprecated) commitments, and the output records show numbers based on those clusters.
The report script itself is
lib/reports/weeding_decision.rb, with tests inspec/reports/weeding_decision_spec.rbandspec/phctl_spec.rb.The changes to
lib/phctl.rbandlib/sidekiq_jobs.rbmake the report possible to run from inside a running container using: