SPO-41: make SharedPrint::Phase3Validator support other_commitments #279
Conversation
|
I have tested this in dev with the production file Tufts_print_retention_20230706.tsv and it works (given the proper setup). I'd like to release this asap so I can move a couple of operational tickets along. |
| @@ -85,5 +86,14 @@ def deprecation_validation | |||
| errors.add(:deprecation_date, "can't be set without a deprecation status.") | |||
| end | |||
| end | |||
|
|
|||
| # If one of other_program/other_retention_date is set they must both be set | |||
| def other_commitment_validation | |||
There was a problem hiding this comment.
We have a couple of these fields that are linked together now (other commitment & deprecation) - it might be worth representing those at least in the code (if not in the actual data store) as their own object. Not a change we'd need to make now, but worth thinking about especially as we add additional reporting based on those fields.
There was a problem hiding this comment.
Agreed. There is some creep towards that, and it should be monitored in case there's a smell.
There was a problem hiding this comment.
This is all clear enough to me. We are starting to see some issues emerging with data clumps within commitment that suggest we should start thinking about commitment as being composed of multiple objects, but that can certainly be a future change rather than something to do right now.
The (user facing) specs say you can submit commitments with the field
other_commitments, and that field did exist, but the commitments loader had no code that knew how parse that field.This PR adds capability to deal with
other_commitments.