DEV-1531: verify blank n_enum isn't an mpm #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aelkiss
force-pushed
the
DEV-1531-calculate-format-mpm
branch
from
ea21230 to
e54b561
Compare
aelkiss
commented
Feb 7, 2025
spec/calculate_format_spec.rb
Outdated
| @@ -34,6 +34,24 @@ | |||
| ).to eq("spm") | |||
| end | |||
|
|
|||
| it "is NOT an MPM with null n_enum" do | |||
| htitem = double(:htitem, ht_bib_key: '12345', bib_fmt: 'BK', n_enum: nil) | |||
There was a problem hiding this comment.
Rather than trying to get the htitem/cluster to do what we wanted, basically we say -- what if htitem behaves like this? Then CalculateFormat should behave the way we want.
Ensure that regardless of whether we get a blank or nil n_enum, CalculateFormat says the item is not a multi-part monograph.
aelkiss
force-pushed
the
DEV-1531-calculate-format-mpm
branch
from
e54b561 to
9b14738
Compare
mwarin
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that regardless of whether we get a blank or nil n_enum, CalculateFormat says the item is not a multi-part monograph.