Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated methods from Cluster #68

Merged
merged 1 commit into from
Jan 8, 2021

Conversation

jsteverman
Copy link
Contributor

The following methods in the Cluster class were untested and unused.
Likely remnants of approaches discarded or refactored.

  • merge
  • merge_many
  • self.merge_many
  • add_ocns
  • billing_entities

  The following methods in the Cluster class were untested and unused.
  Likely remnants of approaches discarded or refactored.
 * merge
 * merge_many
 * self.merge_many
 * add_ocns
 * billing_entities
Copy link
Member

@aelkiss aelkiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, looks like the #merge/#merge_many and #add_ocns was all superceded by ClusterGetter in #50.

@billdueber billdueber merged commit 274961a into master Jan 8, 2021
@aelkiss aelkiss deleted the remove_deprecated_methods branch April 15, 2021 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants