Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HT-2900: Add n_enum and lock_id to overlap reports #79

Merged
merged 1 commit into from
May 3, 2021
Merged

HT-2900: Add n_enum and lock_id to overlap reports #79

merged 1 commit into from
May 3, 2021

Conversation

jsteverman
Copy link
Contributor

Edits bin/export_overlap_report.rb and lib/overlap.rb. Adds columns lock_id and n_enum to holdings_htitem_htmember table.

I don't know what bin/export_etas_overlap_report.rb or lib/etas_overlap.rb are for.

@jsteverman jsteverman force-pushed the HT-2900_n_enum_lockid_overlap_reports branch from e95291a to 4d416f2 Compare April 29, 2021 16:55
aelkiss
aelkiss approved these changes Apr 30, 2021
View reviewed changes
Copy link
Member

@aelkiss aelkiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I like the clarity of the pre-computed lock ID.

@jsteverman jsteverman merged commit ccd3b23 into master May 3, 2021
@aelkiss aelkiss deleted the HT-2900_n_enum_lockid_overlap_reports branch July 22, 2021 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aelkiss aelkiss aelkiss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsteverman @aelkiss