HT-2689: Test that aborted transactions are rolled back #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsteverman
reviewed
May 11, 2021
spec/retryable_spec.rb
Outdated
| expect(Cluster.count).to eq(2) | ||
| end | ||
|
|
||
| it "is only in a transaction the block" do |
There was a problem hiding this comment.
I had trouble parsing the description until I got to the examples. Nitpick.
There was a problem hiding this comment.
That's because it's missing a word.
jsteverman
approved these changes
May 11, 2021
- Ensures Retryable uses transactions - Ensures aborted transactions roll back - Ensures successful transactions are committed - Ensures retried transactions succeed
aelkiss
force-pushed
the
HT-2689-test-rollback
branch
from
5ef6d44 to
83d22d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.