HT-2970 / HT-2940: Update last_modified iff something has changed #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updating holding with new UUID and date received should NOT update |
|
Also we need to fix the holdings equality checking to compare all fields. |
aelkiss
force-pushed
the
HT-2970-htitem-update
branch
from
7f882b4 to
1e34217
Compare
jsteverman
approved these changes
May 28, 2021
There was a problem hiding this comment.
Changes in 7f882b4 look good.
As discussed, we still need to handle the holdings updates.
- Adds tests for ensuring last modified changes when adding or updating holdings, ocn resolution, ht items - Only updates an ht item if something has actually changed
- Don't save the cluster & trigger modify date change if all we did was change the submitted date & uuid on existing holdings - Make sure holdings equality check checks all fields - Refactor holdings tests
aelkiss
force-pushed
the
HT-2970-htitem-update
branch
from
1e34217 to
2ad71e6
Compare
|
Addressed holdings equality & last modified date issue and rebased. |
jsteverman
approved these changes
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #86 ; merge after #86 / #88. Only relevant commit here is 7f882b4
Adds tests for ensuring last modified changes when adding or updating
holdings, ocn resolution, ht items
Only updates an ht item if something has actually changed