Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HT-2909: updates to devops workflows #90

Merged
merged 5 commits into from
Jun 10, 2021
Merged

HT-2909: updates to devops workflows #90

merged 5 commits into from
Jun 10, 2021

Conversation

aelkiss
Copy link
Member

@aelkiss aelkiss commented Jun 9, 2021

  • Update actions to use GitHub Container Registry rather than dockerhub (this seems to be the preference for now)

  • Update tanka to use current k8s library

  • Add wrapper script for creating a Job in kubernetes and an example for running an estimate. tanka isn't really suitable for doing this kind of thing, so for the time being this incorporate the k8s YAML directly. Any updates to the container spec via tanka would need to be manually applied to the wrapper script as well. Perhaps in the future we will have a better way to manage these.

@aelkiss aelkiss requested review from botimer and daaang June 9, 2021 19:07
@aelkiss
Copy link
Member Author

aelkiss commented Jun 9, 2021

@botimer @daaang Just looking for a thumbs-up on the k8s-alpha and ghcr stuff. I know we discussed the question of running jobs -- in this case I generated the YAML via tanka and then pasted it into the shell script. I'm sure there's a better way to do it, but I haven't come across it.

Copy link

@botimer botimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The jsonnet-lib stuff looks good with the possible exception of the kausal import. If you're able to show/diff, I guess it's correct as-is. The change to "all pluses" matches my understanding of the current recommendations -- that is, to flatten all of the mixin calls and let that handle merging, rather than doing any chaining.

bin/run_estimate.sh Outdated Show resolved Hide resolved
bin/run_generic_job.sh Outdated Show resolved Hide resolved
kube/foo/generic-job.yaml Outdated Show resolved Hide resolved
@aelkiss aelkiss force-pushed the HT-2909-generic-job branch from 47c289c to fafa302 Compare June 9, 2021 21:39
@aelkiss aelkiss force-pushed the HT-2909-generic-job branch from fafa302 to 77d255e Compare June 10, 2021 18:24
@aelkiss aelkiss merged commit 607b9f9 into master Jun 10, 2021
@aelkiss aelkiss deleted the HT-2909-generic-job branch June 10, 2021 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants