Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor scrub/load fixes #92

Merged
merged 2 commits into from
Jun 11, 2021
Merged

minor scrub/load fixes #92

merged 2 commits into from
Jun 11, 2021

Conversation

mwarin
Copy link
Contributor

@mwarin mwarin commented Jun 10, 2021

Addressing:

  • bin/process_new_holdings.sh did not recognize .gz files in data/new/
  • issues with nil values in records that had fewer columns than the header
  • lib/autoscrub.rb calculating the wrong batch size for .gz files

aelkiss
aelkiss approved these changes Jun 11, 2021
View reviewed changes
Copy link
Member

@aelkiss aelkiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aelkiss aelkiss merged commit e672363 into master Jun 11, 2021
@aelkiss aelkiss deleted the scrub-fix-20210610 branch July 22, 2021 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aelkiss aelkiss aelkiss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mwarin @aelkiss